Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Fix wrong legacy check #148

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Bugfix: Fix wrong legacy check #148

merged 1 commit into from
Oct 22, 2020

Conversation

gabyx
Copy link
Contributor

@gabyx gabyx commented Oct 21, 2020

  • check variable to be unset

Thx for merging. Small stupid logic error :-)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 886

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 80.325%
Files with Coverage Reduction New Missed Lines %
install.sh 1 67.56%
Totals Coverage Status
Change from base Build 872: 0.0%
Covered Lines: 2372
Relevant Lines: 2953
💛 - Coveralls

rycus86
rycus86 reviewed Oct 21, 2020
View reviewed changes
install.sh Show resolved Hide resolved
@gabyx
Copy link
Contributor Author

gabyx commented Oct 22, 2020

No still swrong

@gabyx
Copy link
Contributor Author

gabyx commented Oct 22, 2020

In the parameter expansions shown previously, use of the colon in the format shall result in a test for a parameter that is unset or null; omission of the colon shall result in a test for a parameter that is only unset. The following table summarizes the effect of the colon:

so ${aaa+thisisset} is correct.
image

Fix wrong legacy check 🎉
139f948 
- check variable to be unset
@gabyx
Copy link
Contributor Author

gabyx commented Oct 22, 2020

Good to merge. Now.

@rycus86 rycus86 merged commit e31094c into rycus86:master Oct 22, 2020
gabyx referenced this pull request in gabyx/Githooks Dec 28, 2020
@gabyx
Integrate latest changes on master: ⚓
16558b4 
between 86d8f0c..6283fab.

- Only added new Git hooks.
- Tests still passing.

Squashed commit of the following:

commit 6283fabf39ad17ea5e9798f02d3642abfa01b4d5
Merge: 864aa3b 8d83c0e
Author: Viktor Adam <[email protected]>
Date:   Sat Nov 28 20:16:48 2020 +1100

    Merge pull request #152 from gabyx/feature/fix-clone-url-settings

    Set clone url/branch always

commit 8d83c0e116ca58b8844d1c1f04ec54eb86062e00
Author: Gabriel Nützi <[email protected]>
Date:   Fri Nov 27 17:13:07 2020 +0100

    Set clone url/branch always :tada:

commit 864aa3b513db34182026d9d76fa5ef081286efdd
Merge: 96f5c05 16fd2a2
Author: Viktor Adam <[email protected]>
Date:   Sat Oct 31 10:09:31 2020 +1100

    Merge pull request #151 from gabyx/feature/faster-pre-commit-hooks

    Faster repository hooks 💜

commit 16fd2a2990bc8e7794dc0ca472812d6b960e5d66
Author: Gabriel Nützi <[email protected]>
Date:   Fri Oct 30 18:29:53 2020 +0100

    Don't add emoji for fixup commit :blue_heart:

commit 2c818484111e622e53dc281a8dc3ab62982f0e3e
Author: Gabriel Nützi <[email protected]>
Date:   Thu Oct 29 18:35:06 2020 +0100

    Faster repository hooks :purple_heart:

commit 96f5c05b5a125e60e0a30a303f5631b6610bdd0b
Merge: f785f5b db3f723
Author: Viktor Adam <[email protected]>
Date:   Thu Oct 29 06:12:31 2020 +1100

    Merge pull request #150 from gabyx/bugfix/set-clone-url-for-fetch-too

    Also set clone url after fetch

commit db3f7232cbde7da2d17dc4e1a463703f1b62d78a
Author: Gabriel Nützi <[email protected]>
Date:   Wed Oct 28 19:01:38 2020 +0100

    Also set clone url after fetch :blue_heart:

    - might be unset when the user deleted the values

commit f785f5b2720e3ef7640a72ee17b71d5cc9210f6d
Merge: e31094c b3e215f
Author: Viktor Adam <[email protected]>
Date:   Wed Oct 28 08:01:18 2020 +1100

    Merge pull request #149 from gabyx/bugfix/redirect-install-execution

    Redirect also the output of install.sh in base-template.sh

commit b3e215f7fc904640d22ded24b670ef2efe8dc08d
Author: Gabriel Nützi <[email protected]>
Date:   Tue Oct 27 21:37:07 2020 +0100

    Redirect output from running install.sh :sparkles:

commit e31094c
Merge: e0607ae 139f948
Author: Viktor Adam <[email protected]>
Date:   Thu Oct 22 17:50:08 2020 +1100

    Merge pull request #148 from gabyx/bugfix/wrong-legacy-check

    Bugfix: Fix wrong legacy check

commit 139f948
Author: Gabriel Nützi <[email protected]>
Date:   Wed Oct 21 17:31:26 2020 +0200

    Fix wrong legacy check :tada:

    - check variable to be unset

commit e0607ae
Merge: 1359038 c855ee9
Author: Viktor Adam <[email protected]>
Date:   Thu Oct 22 05:56:32 2020 +1100

    Merge pull request #147 from gabyx/feature/support-new-hooks

    Feature: Add new hooks in Git 2.28

commit c855ee9
Author: Gabriel Nützi <[email protected]>
Date:   Wed Oct 21 12:30:32 2020 +0200

    Review changes: Dropping support for `fsmonitor-watchman` :green_heart:

commit 317ec4d
Author: Gabriel Nützi <[email protected]>
Date:   Tue Oct 20 21:03:09 2020 +0200

    Test fixes :zap:

commit 21fc07e
Author: Gabriel Nützi <[email protected]>
Date:   Tue Oct 20 20:55:08 2020 +0200

    Add new hooks :blue_heart:
    - all output needs to go to stderr in base-tamplate.sh,
    - since git might read stdin, especially for `fsmonitor-watchman`.
    - add documentation

commit 1359038
Merge: f71bafd a669020
Author: Viktor Adam <[email protected]>
Date:   Mon Oct 19 23:10:31 2020 +1100

    Merge pull request #146 from gabyx/bugfix/ignore-output-legacy-transform

    Bugfix: Fix output and make legacy transform more agnostic

commit a669020
Author: Gabriel Nützi <[email protected]>
Date:   Mon Oct 19 13:49:05 2020 +0200

    Fix output and make legacy transform more agnostic :zap:

commit f71bafd
Merge: 81212e1 86d8f0c
Author: Viktor Adam <[email protected]>
Date:   Mon Oct 19 08:47:22 2020 +1100

    Merge pull request #144 from gabyx/bugfix/wrong-shared-local-path-check

    Bugfix: Fix wrong output for local urls.

commit 86d8f0c
Author: Gabriel Nützi <[email protected]>
Date:   Sun Oct 18 23:35:51 2020 +0200

    Fix wrong output for local urls :yellow_heart:
@gabyx gabyx deleted the bugfix/wrong-legacy-check branch December 28, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycus86 rycus86 rycus86 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabyx @coveralls @rycus86