Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resizes and aligns wasm images (#830) #874

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

JonathanMH
Copy link
Contributor

@JonathanMH JonathanMH commented Jun 10, 2019

Hi!

This is a pull request potentially fixing both the alignment and the sizing (#830) issues on the wasm page.

The added classes controlling height seemed appropriate to not have to version images in different crops and aspect ratios.

This is my first time using tachyons, feedback very welcome!

rust-image-align-fix

@Manishearth Manishearth requested a review from skade June 10, 2019 21:02
@skade
Copy link
Contributor

skade commented Jun 11, 2019

That works, thanks!

@skade skade merged commit 45049ae into rust-lang:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants