Use builder pattern for ListFormatting #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrc
reviewed
Aug 3, 2018
src/lists.rs
Outdated
| pub trailing_separator: SeparatorTactic, | ||
| pub separator_place: SeparatorPlace, | ||
| pub shape: Shape, | ||
| pub(self) tactic: DefinitiveListTactic, |
There was a problem hiding this comment.
Why use pub(self) here? Is it not the same as private?
There was a problem hiding this comment.
Yeah you are right...not sure what I was thinking at the moment 😁
1a6df18 Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces builder pattern for constructing
ListFormatting. This greatly simplifies the code, but more importantly, I think that this makes the further updates and refactoring much easier.r? @nrc