Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show backtrace on Fuchsia #64323

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

cramertj
Copy link
Member

@cramertj cramertj commented Sep 9, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 9, 2019
@alexcrichton
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Sep 9, 2019

📌 Commit 7e23c6d61d1c9f3d671a891b9ab0f35b98d08a64 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2019
@Centril
Copy link
Contributor

Centril commented Sep 9, 2019

@bors r- PR builder failed.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 9, 2019
@rust-highfive
Copy link
Collaborator

The job mingw-check of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-09-09T21:41:55.0792495Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-09T21:41:55.0980180Z ##[command]git config gc.auto 0
2019-09-09T21:41:55.1055700Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-09T21:41:55.1105145Z ##[command]git config --get-all http.proxy
2019-09-09T21:41:55.1244244Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64323/merge:refs/remotes/pull/64323/merge
---
2019-09-09T21:48:05.8255969Z     Checking backtrace v0.3.37
2019-09-09T21:48:07.7744965Z     Checking rustc-std-workspace-alloc v1.0.0 (/checkout/src/tools/rustc-std-workspace-alloc)
2019-09-09T21:48:07.8117840Z     Checking panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
2019-09-09T21:48:07.9382237Z     Checking hashbrown v0.5.0
2019-09-09T21:48:08.8037356Z error: expected one of `.`, `;`, `?`, `}`, or an operator, found `,`
2019-09-09T21:48:08.8037944Z    --> src/libstd/sys_common/backtrace.rs:123:36
2019-09-09T21:48:08.8038183Z     |
2019-09-09T21:48:08.8038398Z 123 |         return Some(PrintFmt::Full),
2019-09-09T21:48:08.8038716Z     |                                    ^ expected one of `.`, `;`, `?`, `}`, or an operator here
2019-09-09T21:48:13.0519255Z error: aborting due to previous error
2019-09-09T21:48:13.0520949Z 
2019-09-09T21:48:13.0883881Z error: Could not compile `std`.
2019-09-09T21:48:13.0884208Z 
---
2019-09-09T21:48:13.0959787Z == clock drift check ==
2019-09-09T21:48:13.0974200Z   local time: Mon Sep  9 21:48:13 UTC 2019
2019-09-09T21:48:13.2481474Z   network time: Mon, 09 Sep 2019 21:48:13 GMT
2019-09-09T21:48:13.2486098Z == end clock drift check ==
2019-09-09T21:48:20.6516609Z ##[error]Bash exited with code '1'.
2019-09-09T21:48:20.6546559Z ##[section]Starting: Checkout
2019-09-09T21:48:20.6548071Z ==============================================================================
2019-09-09T21:48:20.6548113Z Task         : Get sources
2019-09-09T21:48:20.6548148Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@cramertj
Copy link
Member Author

cramertj commented Sep 9, 2019

@bors r=alexcrichton rollup

@bors
Copy link
Contributor

bors commented Sep 9, 2019

📌 Commit 7eb42c9 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 9, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 10, 2019
…p, r=alexcrichton

Always show backtrace on Fuchsia

r? @alexcrichton

cc @JakeEhrlich
bors added a commit that referenced this pull request Sep 10, 2019
Rollup of 4 pull requests

Successful merges:

 - #64307 (Update clippy)
 - #64308 (Update miri submodule)
 - #64318 (update reference)
 - #64323 (Always show backtrace on Fuchsia)

Failed merges:

r? @ghost
@bors bors merged commit 7eb42c9 into rust-lang:master Sep 10, 2019
@cramertj cramertj deleted the fuchsia-rust-backtrace-noop branch September 10, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants