Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework opaque type region inference #116891

Merged
merged 12 commits into from
Mar 28, 2024
Merged

rework opaque type region inference #116891

merged 12 commits into from
Mar 28, 2024
+879 −345

Commits on Mar 26, 2024

  1. fix ICE in check_unique

    @aliemjay
    aliemjay committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    92f40b8 View commit details
    Browse the repository at this point in the history

  2. ignore uncaptured lifetimes when checking opaques

    @aliemjay
    aliemjay committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    4e1999d View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. except equal parameters from the uniqueness check

    @aliemjay
    aliemjay committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    4ecdf5f View commit details
    Browse the repository at this point in the history

  2. ignore error params

    @aliemjay
    aliemjay committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c337825 View commit details
    Browse the repository at this point in the history

  3. check RPITs for invalid args

    @aliemjay
    aliemjay committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    ce91e46 View commit details
    Browse the repository at this point in the history

  4. favor placeholders over existentials when choosing SCC representatives 

    ... even when the existential has the least RegionVid.

universal regions (of root universe) > placeholders > existentials

The previous behavior, that chooses the minimal RegionVid index, naturally prefers universal regions over others
because they always have the least RegionVids, but there was no guranteed ordering between placeholders and existentials.
    @aliemjay
    aliemjay committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    15c7e59 View commit details
    Browse the repository at this point in the history

  5. convert all named regions in opaque types to nll vars 

    Do it in typeck before entering region inference routines
particularly because we will no longer be able to convert placeholders.
    @aliemjay
    aliemjay committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    08c8caa View commit details
    Browse the repository at this point in the history

  6. rework opaque types region inference

    @aliemjay
    aliemjay committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    f4940e4 View commit details
    Browse the repository at this point in the history

  7. reject external lifetimes as invalid arguments

    @aliemjay
    aliemjay committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    6b6ed2e View commit details
    Browse the repository at this point in the history

  8. simplify check_unique

    @aliemjay
    aliemjay committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7c6876f View commit details
    Browse the repository at this point in the history

  9. fixup except equal params from

    @aliemjay
    aliemjay committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    fb35156 View commit details
    Browse the repository at this point in the history

  10. remove test FIXME re once-module-region

    @aliemjay
    aliemjay committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    59c217f View commit details
    Browse the repository at this point in the history