Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Give users control over feature unification #3692

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
97d49c2
Skeleton
epage Sep 11, 2024
c3b17e8
Initial
epage Sep 11, 2024
a921e09
Set RFC number
epage Sep 11, 2024
7d6810d
Fix typo
epage Sep 12, 2024
5b13f93
Fix typo
epage Sep 12, 2024
750b5f1
Fix typo
epage Sep 12, 2024
4ebf0ff
Remove boilerplate
epage Sep 12, 2024
703a636
Remove copy/pasted header
epage Sep 12, 2024
e7a4f27
Move mutually exclusive features to a Drawback
epage Sep 12, 2024
f2bb64a
Cover no_std with std features being unified
epage Sep 12, 2024
c5bbeee
Fix typo
epage Sep 12, 2024
65e6988
Note cargo-hakari's build/host unification features
epage Sep 12, 2024
e752830
Add build/host unification qualification
epage Sep 12, 2024
0cebf5f
Fix typo
epage Sep 12, 2024
363be82
Add citation
epage Sep 12, 2024
6860e51
Note ecosystem importance of build/host unification
epage Sep 12, 2024
8b114b3
Fix typos
epage Sep 12, 2024
4bbdc51
fix: Clarify some points
epage Sep 17, 2024
8f848a4
Expand on future possibilities
epage Sep 17, 2024
c2a4ac1
Expand on dev/normal unification
epage Sep 17, 2024
d35c626
fix: Typo
epage Sep 19, 2024
760b618
fix: Clarify statement
epage Sep 19, 2024
cf07a12
fix: Whatever
epage Sep 19, 2024
51839e5
fix: Clarify statements
epage Sep 19, 2024
6318f47
fix: Clarify statement
epage Sep 19, 2024
cd2af9a
fix: Typi
epage Sep 19, 2024
1b2a3d2
fix: Clarify statement
epage Sep 19, 2024
eb8ffb2
fix: Typo
epage Sep 19, 2024
ff5e82a
fix: Link out to another related Issue
epage Sep 20, 2024
0aac9ab
fix: Remove issue link
epage Sep 30, 2024
c0158e7
fix: Disambiguate each use of 'target'
epage Oct 1, 2024
969cb03
Make cargo-install interaction explicit
epage Oct 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add citation
  • Loading branch information
epage committed Sep 12, 2024
commit 363be827ead2ee13d291d5a74fce8901e0e5d9d6
2 changes: 1 addition & 1 deletion text/3692-feature-unification.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ This is done in the config instead of the manifest:

- This keeps build/host feature unification behavior delegated to `workspace.resolver`
- `cargo hakari` exposes multiple ways to configure this, see [unify-target-host](https://docs.rs/cargo-hakari/latest/cargo_hakari/config/index.html#unify-target-host)
- For Oxide this reduced build units from 1900 to 1500, dramatically improving compile times (remembered off the top of head)
- For Oxide this reduced build units from 1900 to 1500, dramatically improving compile times, see https://github.com/oxidecomputer/omicron/pull/4535
- However, this required effort to make sure additional settings are unified between host and target
- This might be somewhat related to [`-Ztarget-applies-to-host`](https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#target-applies-to-host)

Expand Down