Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pulldown-cmark 0.5. #898

Merged
merged 5 commits into from
Jun 11, 2019

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Apr 22, 2019

  • Update to 0.5.2.
  • Remove pulldown-cmark-to-cmark and de-emphasis test, incompatible with 0.5.

@ehuss
Copy link
Contributor Author

ehuss commented Apr 22, 2019

This includes a temporary hack to deal with pulldown-cmark-to-cmark needing to be updated (see Byron/pulldown-cmark-to-cmark#2). Can either wait for that PR to be merged, or remove the example altogether, or leave the hack.

This causes some changes in rendering in various rust-lang books since pulldown-cmark better conforms to the markdown spec. If this is merged, there will need to be some coordination in updating the books to fix some bugs. I can handle that, just a heads up. Not sure if this warrants bumping to 0.3 (I don't think so).

@Dylan-DPC-zz
Copy link

Thanks. i'd prefer to wait for that PR to be merged.

@Dylan-DPC-zz Dylan-DPC-zz added the S-Blocked-Upstream Status: Blocked Upstream label Apr 24, 2019
@ehuss ehuss mentioned this pull request Apr 29, 2019
remexre added a commit to remexre/ia that referenced this pull request May 10, 2019
@ehuss ehuss mentioned this pull request May 17, 2019
2 tasks
@ehuss ehuss changed the title Update to pulldown-cmark 0.4.1. Update to pulldown-cmark 0.5.1. May 21, 2019
@ehuss ehuss force-pushed the update-pulldown-cmark branch 2 times, most recently from 98dbc8f to 1e31017 Compare May 21, 2019 23:55
@ehuss
Copy link
Contributor Author

ehuss commented May 21, 2019

I have updated this to 0.5 and removed the pulldown-cmark-to-cmark dependency. I think the no-op example is sufficient to demonstrate how to make a preprocessor. The de-emphasis one didn't work by itself, anyways. I did make a demo using comrak instead (ehuss@98dbc8f if you're curious), which works better than the original. But I think the additional dependencies are too heavy, and it seems to be getting a little convoluted for a simple demonstration.

@ehuss ehuss removed the S-Blocked-Upstream Status: Blocked Upstream label May 25, 2019
@Dylan-DPC-zz
Copy link

@ehuss can you resolve the conflicts on this?

@tesuji
Copy link
Contributor

tesuji commented May 26, 2019

@ehuss You have conflict to solve.

@ehuss
Copy link
Contributor Author

ehuss commented May 26, 2019

Updated!

@tesuji
Copy link
Contributor

tesuji commented Jun 1, 2019

I think you need a rebase and update pulldown-cmark to 0.5.2 .
r=me with nits fixed.

ehuss added 4 commits May 31, 2019 18:54
Since it is not compatible with the new pulldown-cmark. This example isn't
directly usable, anyways, and I think the no-op example sufficiently shows how
to make a preprocessor.
@ehuss ehuss changed the title Update to pulldown-cmark 0.5.1. Update to pulldown-cmark 0.5. Jun 1, 2019
@ehuss
Copy link
Contributor Author

ehuss commented Jun 1, 2019

Thanks @lzutao. I wish github would notify automatically like bors does.

@Dylan-DPC-zz Dylan-DPC-zz merged commit 3cfed10 into rust-lang:master Jun 11, 2019
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this pull request Aug 30, 2020
* Update to pulldown-cmark 0.4.1.

* Update to pulldown-cmark 0.5.2.

* Remove pulldown-cmark-to-cmark dependency.

Since it is not compatible with the new pulldown-cmark. This example isn't
directly usable, anyways, and I think the no-op example sufficiently shows how
to make a preprocessor.

* cargo fmt

* Fix example link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants