Make code buttons appear on hover (or tap on mobile) #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the ACE editor still has overlap (see comments for explanation). I'd still consider hiding the buttons with a hover rule. It would also need a tap handler for mobile. I figure that is something that could possibly be added later. I kinda like the balanced vertical whitespace in this change regardless. It still doesn't look great when the first line is long:
but I think this is a little bit of an improvement over the old. |
This was referenced May 17, 2022
ehuss
changed the title
|
I'm going to go ahead and move forward with this. I haven't gotten much feedback, but I kinda like it overall. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes it so that code buttons will appear on hover (similar to how many other sites like GitHub do it). This also has various tweaks to the overall spacing to give some more breathing room.
For implicit main, it no longer adds a blank line at top.
Closes #1322
Closes #1433