Add chapter name to search result breadcrumbs #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
Thanks for the PR! I agree the old breadcrumbs were a little strange, I'm uncertain why they work they way they do.
One minor oddity with this is that if it matches the top-level heading, then it will be duplicated. For example, searching for "highlight" in mdbook's guide has a breadcrumb of "Format » Theme » Syntax highlighting » Syntax Highlighting". I don't think this is too much of a problem, so we can probably tweak it later if it seems too annoying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the search result breadcrumbs only contain the chapter's parents, and not the chapter name itself.
This PR adds the chapter name to the breadcrumbs for improved searchability.