Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caching of supported compiler flag #1002

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Fix caching of supported compiler flag #1002

merged 1 commit into from
Mar 28, 2024

Conversation

NobodyXu
Copy link
Collaborator

@NobodyXu NobodyXu commented Mar 8, 2024

The cache needs to include compiler, since user can always changes the compiler by Build::compiler or by setting/changing environment variables.

This commit also enables different is_flag_supported to be run in parallel.

@NobodyXu NobodyXu requested a review from thomcc March 8, 2024 09:16
@NobodyXu NobodyXu marked this pull request as ready for review March 8, 2024 09:16
The cache needs to include compiler, since user can always changes the compiler
by `Build::compiler` or by setting/changing environment variables.

Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu NobodyXu merged commit be62f4a into main Mar 28, 2024
42 checks passed
@NobodyXu NobodyXu deleted the fix/cache branch March 28, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant