Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(registry): make sure to process a download after it has completed #14680

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(registry): make sure to process a download after it has completed #14680

wants to merge 1 commit into from

Conversation

x-hgg-x
Copy link
Contributor

@x-hgg-x x-hgg-x commented Oct 12, 2024

What does this PR try to resolve?

This PR solves the bug found in Eh2406/pubgrub-crates-benchmark#6 (comment).

With this PR we can avoid refetching the same dependency multiple times because a finished download was not processed before returning from the block_until_ready() method. It also improves the resolving speed since activate_deps_loop() is called less times overall.

@rustbot
Copy link
Collaborator

rustbot commented Oct 12, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-registries Area: registries A-sparse-registry Area: http sparse registries S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2024
@x-hgg-x x-hgg-x mentioned this pull request Oct 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
A-registries Area: registries A-sparse-registry Area: http sparse registries S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@x-hgg-x @rustbot @ehuss