Skip to content
This repository has been archived by the owner on Apr 15, 2020. It is now read-only.

eos package update 0.12.1 #825

Merged
merged 4 commits into from
Jun 6, 2017
Merged

Conversation

headupinclouds
Copy link
Contributor

  • add new hunter_add_version( .. 0.12.1 …)
  • order releases from newest (top) to oldest (bottom)
  • bump default version to 0.12.1

* add new  hunter_add_version( .. 0.12.1 …)
* order releases from newest (top) to oldest (bottom)
* bump min version
@ruslo
Copy link
Owner

ruslo commented Jun 5, 2017

@ruslo
Copy link
Owner

ruslo commented Jun 6, 2017

*Config.cmake is not installed:

CMake Error at CMakeLists.txt:13 (find_package):
  Could not find a package configuration file provided by "eos" with any of
  the following names:
    eosConfig.cmake

@headupinclouds
Copy link
Contributor Author

Oops. I don't know how I missed that. I will add the usual install section.

fix config install
@headupinclouds
Copy link
Contributor Author

Take two.

@ruslo
Copy link
Owner

ruslo commented Jun 6, 2017

CMake Error at /home/travis/build/ingenue/hunter/_ci/cmake/share/cmake-3.8/Modules/CMakeFindDependencyMacro.cmake:35 (message):
  Invalid arguments to find_dependency
Call Stack (most recent call first):
  /home/travis/build/ingenue/hunter/_testing/Hunter/_Base/2ddd996/b1ed1e0/8456c41/Install/lib/cmake/eos/eosConfig.cmake:6 (find_dependency)
  CMakeLists.txt:13 (find_package)

@headupinclouds
Copy link
Contributor Author

headupinclouds commented Jun 6, 2017

Line 6 in my installed eosConfig.cmake is find_dependency(Boost CONFIG REQUIRED). I guess this needs the list of required components (EDIT: and no REQUIRED). I should probably make a local package "installation test" prior to sending the PR to catch this type of thing.

1	
2	
3	include(CMakeFindDependencyMacro)
4	
5	find_dependency(OpenCV REQUIRED)
6	find_dependency(Boost CONFIG REQUIRED)
7	find_dependency(Eigen3 CONFIG REQUIRED)
8	find_dependency(cereal CONFIG REQUIRED)
9	find_dependency(glm REQUIRED)
10	find_dependency(nanoflann CONFIG REQUIRED)
11	find_dependency(eigen3-nnls CONFIG REQUIRED)
12	
13	include("${CMAKE_CURRENT_LIST_DIR}/eosTargets.cmake")
14	check_required_components("eos")

@ruslo
Copy link
Owner

ruslo commented Jun 6, 2017

I should probably make a local package "installation test" prior to sending the PR to catch this type of thing

You can use jenkins.py:

Just for your info I found an issue with OpenCV and latest CMake version we are using in testing. Working on it...

@headupinclouds
Copy link
Contributor Author

TOOLCHAIN=default PROJECT_DIR=examples/eos ./jenkins.py --verbose ==

Generate: 0:01:11.029119s
Build: 0:00:01.657792s
-
Total: 0:01:12.687292s
-
SUCCESS

@headupinclouds
Copy link
Contributor Author

we should expect VERSION < --std=c++11 or --std=c++14 will fail. although i think many recent c++11 compilers will support a subset of c++14 features w/ a warning.

@ruslo ruslo merged commit 5b4062f into ruslo:master Jun 6, 2017
@ruslo
Copy link
Owner

ruslo commented Jun 6, 2017

@headupinclouds headupinclouds deleted the pr.eos.v.0.12.1 branch June 6, 2017 22:48
@ruslo
Copy link
Owner

ruslo commented Jun 6, 2017

@headupinclouds
Copy link
Contributor Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants