Add OpenBLAS 0.3.0 #1468
Add OpenBLAS 0.3.0 #1468
Conversation
| endif() | ||
| hunter_cacheable(OpenBLAS) | ||
| hunter_download( | ||
| PACKAGE_NAME OpenBLAS | ||
| PACKAGE_INTERNAL_DEPS_ID "2" | ||
| PACKAGE_UNRELOCATABLE_TEXT_FILES |
There was a problem hiding this comment.
This change will break old versions like 0.2.20-p0.
As far as I can see since version 0.3.0-p2 we will not need OpenBLAS custom build scheme, right? In this case I'm okay with removing 0.2.* versions since changing custom build scheme to CMake based build scheme is a super cool event :) We will not need PACKAGE_INTERNAL_DEPS_ID and PACKAGE_UNRELOCATABLE_TEXT_FILES in this case too.
There was a problem hiding this comment.
Or is there a way to make the PACKAGE_UNRELOCATABLE_TEXT_FILES use a dummy file for CMake instead?
I suppose hunter_configuration_types(OpenBLAS CONFIGURATION_TYPES Release) isn't needed either for CMake.
There was a problem hiding this comment.
Or is there a way to make the package_unrelocatable_text_files depend on some variable?
if(HUNTER_OpenBLAS_VERSION VERSION_LESS 0.3.0)
set(
_openblas_unrelocatable_text_files
PACKAGE_UNRELOCATABLE_TEXT_FILES
"lib/cmake/openblas/OpenBLASConfig.cmake
)
else()
set(_openblas_unrelocatable_text_files "")
endif()
hunter_download(
PACKAGE_NAME OpenBLAS
PACKAGE_INTERNAL_DEPS_ID "2"
${_openblas_unrelocatable_text_files}
)There was a problem hiding this comment.
OK, I've done that. Also made MSVC consistent (it didn't work previously in 0.2.20 anyway).
I've tested this package remotely and have excluded all broken builds.
Here is the links to the Travis/AppVeyor with status "All passed":
Update: Merged commits in to one