Skip to content
This repository has been archived by the owner on Apr 15, 2020. It is now read-only.

Add dlib 19.10 #1388

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Add dlib 19.10 #1388

merged 1 commit into from
Mar 23, 2018

Conversation

xsacha
Copy link
Contributor

@xsacha xsacha commented Mar 23, 2018

@ruslo ruslo merged commit dbf1ddc into ruslo:master Mar 23, 2018
@ruslo
Copy link
Owner

ruslo commented Mar 23, 2018

@xsacha
Copy link
Contributor Author

xsacha commented Mar 25, 2018

Strange, I now try to use this in my project and get an error:
Unknown CMake command "check_required_components".

@ruslo
Copy link
Owner

ruslo commented Mar 25, 2018

configure_file(cmake_utils/dlibConfig.cmake.in "${CMAKE_CURRENT_BINARY_DIR}/config/dlibConfig.cmake" @ONLY)

@xsacha Should be configure_package_config_file , not just configure_file. I think that current testing use all dependencies and check_required_components loaded from one of the find_package calls from Config.cmake.in. I guess you have minimal configuration without dependencies.

@xsacha
Copy link
Contributor Author

xsacha commented Mar 25, 2018

That's true, we configure without any dependencies but I didn't have any issues on 19.8.
It's very confusing because dlib previously didn't have a configure/install and has just added it in 19.10.
I tried to keep as much the same from upstream as possible but enough from Hunter so it works fine with Hunter.

@ruslo
Copy link
Owner

ruslo commented Mar 25, 2018

I tried to keep as much the same from upstream as possible but enough from Hunter so it works fine with Hunter.

This change is not Hunter related, it's worth adding it upstream as general improvement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants