Skip to content
This repository has been archived by the owner on Apr 15, 2020. It is now read-only.

add boringssl + test #1186

Merged
merged 2 commits into from
Nov 12, 2017
Merged

add boringssl + test #1186

merged 2 commits into from
Nov 12, 2017

Conversation

headupinclouds
Copy link
Contributor

No description provided.

Copy link
Owner

@ruslo ruslo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@headupinclouds
Copy link
Contributor Author

headupinclouds commented Nov 11, 2017

I hit this during an earlier look at boringssl. I must have installed go on my local machine previously. If this is a build dependency (similar to a compiler, etc), and not a package dependency, I think it is reasonable to use apt-get or homebrew to configure this in the CI scripts. Thoughts?

Ubuntu:

sudo apt-get install golang-go

OS X:

sudo brew install hg
sudo brew install go

@ruslo
Copy link
Owner

ruslo commented Nov 11, 2017

I think it is reasonable to use apt-get or homebrew to configure this in the CI scripts. Thoughts?

I've added installation of Go on Linux. On OSX it seems to be installed already.

Testing:

@ruslo
Copy link
Owner

ruslo commented Nov 12, 2017

Testing

-- The ASM_NASM compiler identification is unknown
-- Didn't find assembler
CMake Error at crypto/CMakeLists.txt:59 (enable_language):
  No CMAKE_ASM_NASM_COMPILER could be found.

This patch should do the trick.

@headupinclouds
Copy link
Contributor Author

headupinclouds commented Nov 12, 2017

boringssl

Both osx-10-11 and ios-nocodesign-9-* are failing.

I wish there was a nice way to show travis + appveyor summaries directly in PR's.

@headupinclouds
Copy link
Contributor Author

This patch should do the trick.

Copy and paste: 2493253

@ruslo ruslo merged commit ae98e4f into ruslo:master Nov 12, 2017
@ruslo
Copy link
Owner

ruslo commented Nov 12, 2017

Follow up: 2a00835

Released: https://github.com/ruslo/hunter/releases/tag/v0.19.152

Usage of this library raise this issue: https://github.com/ruslo/hunter/issues/1191

dvirtz pushed a commit to dvirtz/hunter that referenced this pull request Nov 30, 2017
@headupinclouds headupinclouds deleted the pr.boringssl branch January 28, 2018 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants