Skip to content
This repository has been archived by the owner on Apr 15, 2020. It is now read-only.

Add glbinding 2.1.3-p0 package #1073

Merged
merged 2 commits into from
Oct 5, 2017
Merged

Add glbinding 2.1.3-p0 package #1073

merged 2 commits into from
Oct 5, 2017

Conversation

NeroBurner
Copy link
Contributor

No description provided.

- `Official <https://github.com/cginternals/glbinding>`__
- `Hunterized <https://github.com/hunter-packages/glbinding>`__
- `Example <https://github.com/ruslo/hunter/blob/master/examples/glbinding/CMakeLists.txt>`__
- Added by `NeroBurner <https://github.com/NeroBurner>`__ (`pr-N <https://github.com/ruslo/hunter/pull/N>`__)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s,pr-N,pr-1073,

target_link_libraries(foo glbinding::glbinding)

# glbinding needs at least this c++11 feature
target_compile_features(foo PRIVATE cxx_defaulted_move_initializers)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++11 will be added by toolchain. Not needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep something in for future reference. When someone is using this package in his project he will need to enable this compile-feature or C++11. Not everyone is using a toolchain to enable C++11

@NeroBurner
Copy link
Contributor Author

tests succeeded :)

what shall I do because of the compile feature cxx_defaulted_move_initializers?

@ruslo ruslo merged commit 426a61c into ruslo:master Oct 5, 2017
@ruslo
Copy link
Owner

ruslo commented Oct 5, 2017

what shall I do because of the compile feature cxx_defaulted_move_initializers?

I've already finished testing so I guess nothing. My point is that we don't need it in examples because C++11 standard is set by toolchain while testing. Also setting C++ standard locally may cause ODR problems, it should be set globally:

Uploading:

@ruslo
Copy link
Owner

ruslo commented Oct 5, 2017

Released: https://github.com/ruslo/hunter/releases/tag/v0.19.118

@NeroBurner NeroBurner deleted the pr.glbinding branch October 6, 2017 10:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants