-
Notifications
You must be signed in to change notification settings - Fork 650
Conversation
docs/packages/pkg/glbinding.rst
Outdated
- `Official <https://github.com/cginternals/glbinding>`__ | ||
- `Hunterized <https://github.com/hunter-packages/glbinding>`__ | ||
- `Example <https://github.com/ruslo/hunter/blob/master/examples/glbinding/CMakeLists.txt>`__ | ||
- Added by `NeroBurner <https://github.com/NeroBurner>`__ (`pr-N <https://github.com/ruslo/hunter/pull/N>`__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s,pr-N,pr-1073,
target_link_libraries(foo glbinding::glbinding) | ||
|
||
# glbinding needs at least this c++11 feature | ||
target_compile_features(foo PRIVATE cxx_defaulted_move_initializers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++11 will be added by toolchain. Not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to keep something in for future reference. When someone is using this package in his project he will need to enable this compile-feature or C++11. Not everyone is using a toolchain to enable C++11
tests succeeded :) what shall I do because of the compile feature |
I've already finished testing so I guess nothing. My point is that we don't need it in examples because C++11 standard is set by toolchain while testing. Also setting C++ standard locally may cause ODR problems, it should be set globally: Uploading: |
No description provided.