core: Make applyFilter with zero-sized rects noops #17965
Merged
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian17
force-pushed
the
noop-zero-applyfilter
branch
from
103f62a
to
828ff8f
Compare
adrian17
changed the title
adrian17
added
A-rendering
Dinnerbone
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Looks good to me, thank you!
I was initially concerned that we might not catch things that are effectively zero, but I think in practice filters grow the size so an effective zero might end up being a positive value, and I think our rendering should handle that fine as long as the source size isn't zero; so this should be good, I think!
torokati44
approved these changes
Sep 17, 2024
torokati44
force-pushed
the
noop-zero-applyfilter
branch
from
828ff8f
to
54f4c75
Compare
|
On hold until the Discord questions are resolved. |
|
(converted to draft accordingly) |
adrian17
force-pushed
the
noop-zero-applyfilter
branch
from
54f4c75
to
929d181
Compare
adrian17
force-pushed
the
noop-zero-applyfilter
branch
3 times, most recently
from
de83609
to
472685c
Compare
Dinnerbone
approved these changes
Sep 20, 2024
|
Strangely, #17964 seems to have been deleted. I've archived it from Google's cache for future reference: https://archive.is/szqJP |
danielhjacobs
force-pushed
the
noop-zero-applyfilter
branch
from
472685c
to
242acbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified that it fixes #17964 . Hopefully should fix most/all of "dimension X is zero" in applyFilter.
I don't know whether this is the best place (it can be done a layer above and below, and after more clamping). @Dinnerbone can you please check it out?