Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avm2: Correctly differentiate between Any and null Multiname #17890

Merged

Conversation

Lord-McSweeney
Copy link
Collaborator

For example, we now throw a class lookup VerifyError ("Class *::* could not be found") when trying to call a method with return type QName(null, null) instead of incorrectly assuming that the name is the Any name.

This removes the any Multiname from CommonMultinames.

@Lord-McSweeney
Copy link
Collaborator Author

Lord-McSweeney commented Sep 13, 2024

This PR supersedes #17836.

@Lord-McSweeney Lord-McSweeney added A-avm2 T-compat Type: Compatibility with Flash Player labels Sep 15, 2024
@Dinnerbone Dinnerbone added A-avm2 Area: AVM2 (ActionScript 3) and removed A-avm2 labels Sep 15, 2024
@Lord-McSweeney Lord-McSweeney force-pushed the avm2-any-multiname-removal branch 2 times, most recently from 47a61a4 to 9dc15f8 Compare September 16, 2024 23:22
@Lord-McSweeney Lord-McSweeney enabled auto-merge (rebase) September 16, 2024 23:29
@Lord-McSweeney Lord-McSweeney merged commit 4fd9dc4 into ruffle-rs:master Sep 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm2 Area: AVM2 (ActionScript 3) T-compat Type: Compatibility with Flash Player
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants