avm2: Return actual VerifyErrors for constant pool errors #17866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
force-pushed
the
avm2-better-cpool-errors
branch
2 times, most recently
from
4fe102e
to
4813641
Compare
adrian17
reviewed
Sep 12, 2024
adrian17
approved these changes
Sep 12, 2024
This requires passing around an Activation
Lord-McSweeney
force-pushed
the
avm2-better-cpool-errors
branch
from
4813641
to
55bd559
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires passing around an Activation in some places. The PR also adds better verification for
Classand slot names.Anynamespaces can now only be found in Multinames with aNamespaceSet::Single.