avm2: Cache method body index on Method #17834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| method_bodies.push(self.read_method_body()?); | ||
| for body_idx in 0..len { | ||
| let body = self.read_method_body()?; | ||
| methods[body.method.0 as usize].body = Some(Index::new(body_idx)); |
There was a problem hiding this comment.
If FP verifyerrors here when there is already a Method attached to the MethodBody can we check and panic?
There was a problem hiding this comment.
Do we wanna panic, or just log::warn and continue?
There was a problem hiding this comment.
Oh, this is in swf, so can't really log from there either...
And we ideally shouldn't panic in swf as it's more of a library :/
Gonna Err then.
Lord-McSweeney
approved these changes
Sep 9, 2024
adrian17
force-pushed
the
avm2-faster-load-method
branch
3 times, most recently
from
94c407b
to
a8180c7
Compare
adrian17
force-pushed
the
avm2-faster-load-method
branch
from
a8180c7
to
e82421f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes quadratic behavior observable with >>1000 classes. On Habbo SWF, on desktop it shaves like 100ms and on FF it improves load time by 0.5-1s.