Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use PanicHookInfo instead of PanicInfo #17766

Merged
merged 1 commit into from
Sep 12, 2024
Merged

chore: Use PanicHookInfo instead of PanicInfo #17766

merged 1 commit into from
Sep 12, 2024

Conversation

kjarosh
Copy link
Member

@kjarosh kjarosh commented Sep 5, 2024 •
edited
Loading

torokati44
torokati44 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@torokati44 torokati44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge as soon as Rust 1.81 is out and CI passes. Would be nice to notify folks on Discord to rustup update after. Thanks!

@kjarosh
Copy link
Member Author

kjarosh commented Sep 5, 2024 •
edited
Loading

I'd wait a few days for other distributions to catch up too, otherwise we'd lock up compilation of Ruffle for folks who do not use rustup.

And it's not a critical PR, so IMO we can wait a bit

@torokati44
Copy link
Member

other distributions to catch up

Did you have any specific in mind, or just in general?

@kjarosh
Copy link
Member Author

kjarosh commented Sep 5, 2024

Just in general, for instance Fedora takes a few days to deploy. You can see the current state of deployment here: https://repology.org/project/rust/versions

@kjarosh
Copy link
Member Author

kjarosh commented Sep 6, 2024

Just noting that we may consider rolling back to 1.80.1 due to #17785. In that case this PR cannot be merged yet.

@torokati44 torokati44 mentioned this pull request Sep 10, 2024
Merged
@danielhjacobs danielhjacobs marked this pull request as ready for review September 12, 2024 22:07
@danielhjacobs
Copy link
Contributor

danielhjacobs commented Sep 12, 2024 •
edited
Loading

Between all the other issues, distros have had plenty of time to catch up. Marked as ready for review.

@kjarosh kjarosh merged commit 5760aa7 into ruffle-rs:master Sep 12, 2024
17 checks passed
@kjarosh kjarosh deleted the panic-info branch September 12, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torokati44 torokati44 torokati44 approved these changes

@danielhjacobs danielhjacobs danielhjacobs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjarosh @torokati44 @danielhjacobs