Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to load ttf/otf/ttc/otc as default fonts for ruffle extension #17668

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Ability to load ttf/otf/ttc/otc as default fonts for ruffle extension #17668

merged 1 commit into from
Sep 13, 2024

Conversation

wsxarcher
Copy link
Contributor

No description provided.

@danielhjacobs danielhjacobs added the extension Related to the Ruffle WebExtension label Aug 27, 2024
@wsxarcher wsxarcher changed the title Ability to load ttf/otf/ttc as default fonts for ruffle extension Ability to load ttf/otf/ttc/otc as default fonts for ruffle extension Aug 29, 2024
@danielhjacobs danielhjacobs added the waiting-on-review Waiting on review from a Ruffle team member label Aug 30, 2024
Dinnerbone
Dinnerbone reviewed Aug 30, 2024
View reviewed changes
Copy link
Contributor

@Dinnerbone Dinnerbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just try to load it as a ttf/etc, and then fall back to swf?
I'm not sure this would work if they provide a link to (for example) foo.ttf?ver=123 or a dreaded fonts.php?file=1 (though I hope in 2024 nobody's doing that anymore)

evilpie
evilpie reviewed Aug 30, 2024
View reviewed changes
web/src/builder.rs Outdated Show resolved Hide resolved
evilpie
evilpie reviewed Aug 31, 2024
View reviewed changes
core/src/font.rs Outdated Show resolved Hide resolved
evilpie
evilpie reviewed Aug 31, 2024
View reviewed changes
web/src/builder.rs Outdated Show resolved Hide resolved
evilpie
evilpie reviewed Sep 3, 2024
View reviewed changes
web/src/builder.rs Outdated Show resolved Hide resolved
evilpie
evilpie reviewed Sep 5, 2024
View reviewed changes
web/src/builder.rs Outdated Show resolved Hide resolved
@torokati44
Copy link
Member

torokati44 commented Sep 5, 2024 •
edited
Loading

Could you please rebase this branch on top of current master, resolving the conflicts?

@torokati44
Copy link
Member

I've recreated the final changes of this branch as a single commit, without merges.

@evilpie evilpie added the A-web Area: Web & Extensions label Sep 8, 2024
@evilpie evilpie enabled auto-merge (rebase) September 13, 2024 20:16
@evilpie evilpie merged commit 7d13733 into ruffle-rs:master Sep 13, 2024
17 checks passed
@n0samu n0samu added newsworthy and removed waiting-on-review Waiting on review from a Ruffle team member labels Sep 14, 2024
@Dinnerbone Dinnerbone added A-core Area: Core player, where no other category fits T-feature Type: New Feature (that Flash doesn't have) and removed A-core Area: Core player, where no other category fits labels Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilpie evilpie evilpie approved these changes

@Dinnerbone Dinnerbone Dinnerbone approved these changes

Assignees
No one assigned
Labels
A-web Area: Web & Extensions extension Related to the Ruffle WebExtension newsworthy T-feature Type: New Feature (that Flash doesn't have)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wsxarcher @torokati44 @evilpie @Dinnerbone @danielhjacobs @n0samu