desktop: Internationalize file pickers & improve filters #17604
Conversation
| picker-filter-spl = FutureSplash Animator (*.spl) | ||
| picker-filter-ruf = Ruffle Bundle (*.ruf) |
There was a problem hiding this comment.
FutureSplash Animator probably can't be translated but could perhaps be transliterated
Ruffle Bundle could be translated ("Ruffle" should not, but "Bundle" I think could be)
| picker-filter-spl = FutureSplash Animator (*.spl) | ||
| picker-filter-ruf = Ruffle Bundle (*.ruf) |
There was a problem hiding this comment.
I wonder - what's the chance that these indeed can be translated in any meaningful way to something else than what they currently are? And even if so, do we want that?
There was a problem hiding this comment.
Did we just do the time warp?
There was a problem hiding this comment.
Sorry, I recreated the note right when you replied to it... Because it seems the GH UI is buggy - this was meant to also correspond to SWF (.swf) above...
There was a problem hiding this comment.
Hmm, to me, even "bundle" is near that territory of "jargon" words that are not meant to be messed with... Like "shader" for example.
There was a problem hiding this comment.
I would expect that in most languages they will be the same as in English, however I added entries for them too for the sake of consistency and in case some language will require a translation (e.g. by adding a "file" suffix to SWF because it would be ambiguous otherwise — I don't know, just guessing, but I would have to know every language to make sure it's not needed). Looking for instance at Inkscape, some words might be translatable ("bundle" perhaps?):
kjarosh
force-pushed
the
picker-i18n
branch
2 times, most recently
from
e6d8af1
to
6c85edc
Compare
|
For the record, I'm neutral about this change. Not approving, but not blocking either. 🤷♂️ |
kjarosh
force-pushed
the
picker-i18n
branch
3 times, most recently
from
be44ccf
to
ea56551
Compare
kjarosh
force-pushed
the
picker-i18n
branch
from
ea56551
to
8b27b79
Compare
torokati44
force-pushed
the
picker-i18n
branch
from
8b27b79
to
cc67d53
Compare
sleepycatcoding
removed
the
waiting-on-review
This PR adds internationalization to strings in file pickers and improves a bit their filters.