Add wireframe mode toggle to debug menu #11880
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torokati44
force-pushed
the
wgpu-debug-wireframe
branch
2 times, most recently
from
eaad032
to
c2a7322
Compare
torokati44
force-pushed
the
wgpu-debug-wireframe
branch
from
c2a7322
to
9956423
Compare
torokati44
force-pushed
the
wgpu-debug-wireframe
branch
3 times, most recently
from
bd941ba
to
21e0c9d
Compare
torokati44
force-pushed
the
wgpu-debug-wireframe
branch
from
21e0c9d
to
ff94578
Compare
torokati44
force-pushed
the
wgpu-debug-wireframe
branch
from
ff94578
to
40ae6ed
Compare
torokati44
added
render-wgpu
torokati44
changed the title
torokati44
force-pushed
the
wgpu-debug-wireframe
branch
2 times, most recently
from
8201bde
to
f72a6e4
Compare
|
Now it's done with renderer backend downcasting (desktop with egui can only work with wgpu at the moment anyway), and not through a needlessly inflated RendererBackend trait. Should the "not supported" tooltip be localized? |
torokati44
force-pushed
the
wgpu-debug-wireframe
branch
from
f72a6e4
to
8865c4d
Compare
torokati44
force-pushed
the
wgpu-debug-wireframe
branch
from
8865c4d
to
d205489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a checkbox to toggle wireframe mode to the debug menu.
Doing so by switching to an entirely different set of pipelines, with
PolygonMode::Line, as suggested by @adrian17 and @Dinnerbone.Those are created lazily, so hopefully they won't add any additional startup delay.
I'm not at all sure how this is how it should be done.
My main concern is inflating the
RenderBackendtrait too much with less relevant stuff.