Undo Hash.new workaround, add memory specs #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
key will use the same array, which doesnt work. added a spec to make sure this case is caught even though its a strange case. reverted to code before the workaround, since after adding further specs, there is no way to avoid a retain cycle with the current version of rubymotion. it sounds like the next version of rubymotion will address this. when it does, these specs should pass.
|
👍 good call |
clayallsopp
added a commit
that referenced
this pull request
Jul 22, 2013
Undo Hash.new workaround, add memory specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current workaround is broken.
A different workaround at best only passes 3/4 of the memory specs I have now added. I don't see any benefit to adding an improved workaround when it still wont pass all specs. So I've put the code back to the original, and when the next rubymotion build is out, these specs should pass.
Also, the CI should probably update its copy of rubymotion.