This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Add check for already installed plugin #6978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deivid-rodriguez Is there any more work required in this pr? Can this be merged? 😅 |
|
Sorry, I forgot about this! No more feedback, so merging, yeah! @bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Mar 3, 2019
6978: Add check for already installed plugin r=deivid-rodriguez a=ankitkataria ### What was the end-user problem that led to this PR? Fixes #6946 ### What was your diagnosis of the problem? There was no check to ensure that the plugin was already installed or not. ### What is your fix for the problem, implemented in this PR? I added the check [here](https://github.com/bundler/bundler/compare/master...ankitkataria:plugin-fix?expand=1#diff-68bd939cd3589d8fdda08a12433659ebR109) I also added a small test for the same Co-authored-by: Ankit Kataria <[email protected]>
Build succeeded |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
Fixes #6946
What was your diagnosis of the problem?
There was no check to ensure that the plugin was already installed or not.
What is your fix for the problem, implemented in this PR?
I added the check here
I also added a small test for the same