This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2k
bundler inline fails when BUNDLE_BIN is set (default in docker) #5847
Labels
Comments
Thanks for the 💯 issue! #5848 should fix this. |
Thanks so much @segiddins! 💯 👍 😻 |
bundlerbot
added a commit
that referenced
this issue
Jul 8, 2017
[Inline] Work when BUNDLE_BIN is set ### What was the end-user problem that led to this PR? The problem was that `bundler/inline` would fail when `$BUNDLE_BIN` was set. Closes #5847. ### What was your diagnosis of the problem? My diagnosis was we needed to skip installing binstubs when doing an inline install. ### What is your fix for the problem, implemented in this PR? My fix sets a temporary setting for `:inline` and skips installing binstubs when that's true. ### Why did you choose this fix out of the possible options? I chose this fix because it was minimally intrusive.
segiddins
pushed a commit
that referenced
this issue
Jul 17, 2017
[Inline] Work when BUNDLE_BIN is set ### What was the end-user problem that led to this PR? The problem was that `bundler/inline` would fail when `$BUNDLE_BIN` was set. Closes #5847. ### What was your diagnosis of the problem? My diagnosis was we needed to skip installing binstubs when doing an inline install. ### What is your fix for the problem, implemented in this PR? My fix sets a temporary setting for `:inline` and skips installing binstubs when that's true. ### Why did you choose this fix out of the possible options? I chose this fix because it was minimally intrusive. (cherry picked from commit 1075e44) # Conflicts: # lib/bundler/installer.rb # spec/quality_spec.rb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi there,
I'm trying to use
bundler/inline
feature to dockerize some scripts that require gems to be installed. I was able to reproduce the problem locally, it's doesn't appear to be docker specific issue.Steps to reproduce:
Create example script in
/tmp/inline.rb
:Run the script in official docker container:
Result:
It works when BUNDLE_BIN is unset or
false
:Output of bundle env from docker container:
This is from the official, up to date, ruby docker image. I'm getting exactly same error on my local environment by running
BUNDLE_BIN=/tmp ruby /tmp/inline.rb
.The workaround I'm using now is to simply update the script with
ENV['BUNDLE_BIN'] = nil
at the very top. That works, but it feels to be a bug so I'm creating an issue.Thanks so much for doing awesome work on bundler and taking time to look into this problem!
The text was updated successfully, but these errors were encountered: