Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalatest FuncSuite support #12

Merged
merged 1 commit into from
Aug 16, 2018
Merged

scalatest FuncSuite support #12

merged 1 commit into from
Aug 16, 2018

Conversation

rpau
Copy link
Owner

@rpau rpau commented Aug 16, 2018

This patch adds support for FuncSuite with the following changes:

  • New agent to define for ignoring tests because when the runner loads
    the test ignorer, the class has been already loaded, which means that
    can not be changed.

  • Checking if the test extends from FuncSuite

  • ScalaTest creates a constructor per Test class, and inside the constructor, calls the tests.
    This patch ignores this kind of tests by replacing the method call "test" by "ignore".

This patch adds support for FuncSuite with the following changes:

- New agent to define for ignoring tests because when the runner loads
the test ignorer, the class has been already loaded, which means that
can not be changed.

- Checking if the test extends from FuncSuite

- ScalaTest creates a constructor per Test class, and inside the constructor, calls the tests.
This patch ignores this kind of tests by replacing the method call "test" by "ignore".
@codecov
Copy link

codecov bot commented Aug 16, 2018

Codecov Report

Merging #12 into master will decrease coverage by 11.14%.
The diff coverage is 39.78%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #12       +/-   ##
=============================================
- Coverage     81.83%   70.69%   -11.15%     
- Complexity      128      138       +10     
=============================================
  Files            13       16        +3     
  Lines           435      546      +111     
  Branches         43       52        +9     
=============================================
+ Hits            356      386       +30     
- Misses           49      128       +79     
- Partials         30       32        +2
Impacted Files Coverage Δ Complexity Δ
...unit4git/core/bytecode/TestIgnorerTransformer.java 0% <0%> (ø) 0 <0> (?)
...kmod/junit4git/core/ignorers/TestIgnorerAgent.java 0% <0%> (ø) 0 <0> (?)
...g/walkmod/junit4git/core/ignorers/TestIgnorer.java 62.65% <46.8%> (-19.41%) 22 <7> (+6)
...rg/walkmod/junit4git/javassist/JavassistUtils.java 76.92% <75%> (+2.92%) 15 <4> (+4) ⬆️
...d/junit4git/core/reports/GitTestReportStorage.java 81.25% <0%> (-2.35%) 31% <0%> (ø)
...ain/scala/org/scalatest/junit/ScalaGitRunner.scala 0% <0%> (ø) 0% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 684679d...bef3449. Read the comment docs.

@rpau rpau merged commit 969266e into master Aug 16, 2018
@rpau rpau deleted the rpau-scalatest-agent branch August 16, 2018 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant