Cleanup test fixtures naming

tests/Tactician/Tests/CommandBus/ExecutingCommandBusTest.php

@@ -5,9 +5,9 @@
 use Tactician\CommandBus\ExecutingCommandBus;
 use Tactician\Handler\MethodNameInflector\MethodNameInflector;
 use Tactician\Handler\Locator\HandlerLocator;
-use Tactician\Tests\Fixtures\Command\TaskCompletedCommand;
+use Tactician\Tests\Fixtures\Command\CompleteTaskCommand;
 use Tactician\Tests\Fixtures\Handler\DynamicMethodsHandler;
-use Tactician\Tests\Fixtures\Handler\TaskCompletedHandler;
+use Tactician\Tests\Fixtures\Handler\ConcreteMethodsHandler;
 use stdClass;
 use Mockery;
 
@@ -41,19 +41,19 @@ protected function setUp()
 
     public function testHandlerIsExecuted()
     {
-        $command = new TaskCompletedCommand();
+        $command = new CompleteTaskCommand();
 
-        $handler = Mockery::mock(TaskCompletedHandler::class);
+        $handler = Mockery::mock(ConcreteMethodsHandler::class);
         $handler
-            ->shouldReceive('handleTaskCompletedCommand')
+            ->shouldReceive('handleCompleteTaskCommand')
             ->with($command)
             ->once()
             ->andReturn('a-return-value');
 
         $this->methodNameInflector
             ->shouldReceive('inflect')
             ->withArgs([$command, $handler])
-            ->andReturn('handleTaskCompletedCommand');
+            ->andReturn('handleCompleteTaskCommand');
 
         $this->handlerLocator
             ->shouldReceive('getHandlerForCommand')
@@ -68,7 +68,7 @@ public function testHandlerIsExecuted()
      */
     public function testMissingMethodOnHandlerObjectIsDetected()
     {
-        $command = new TaskCompletedCommand();
+        $command = new CompleteTaskCommand();
 
         $this->methodNameInflector
             ->shouldReceive('inflect')
@@ -83,7 +83,7 @@ public function testMissingMethodOnHandlerObjectIsDetected()
 
     public function testDynamicMethodNamesAreSupported()
     {
-        $command = new TaskCompletedCommand();
+        $command = new CompleteTaskCommand();
         $handler = new DynamicMethodsHandler();
 
         $this->methodNameInflector
@@ -104,7 +104,7 @@ public function testDynamicMethodNamesAreSupported()
 
     public function testClosuresCanBeInvoked()
     {
-        $command = new TaskCompletedCommand();
+        $command = new CompleteTaskCommand();
         $closureWasExecuted = false;
         $handler = function () use (&$closureWasExecuted) {
             $closureWasExecuted = true;

tests/Tactician/Tests/CommandBus/QueueingCommandBusTest.php

@@ -5,8 +5,8 @@
 use Mockery;
 use Tactician\CommandBus\CommandBus;
 use Tactician\CommandBus\QueueingCommandBus;
-use Tactician\Tests\Fixtures\Command\TaskAddedCommand;
-use Tactician\Tests\Fixtures\Command\TaskCompletedCommand;
+use Tactician\Tests\Fixtures\Command\AddTaskCommand;
+use Tactician\Tests\Fixtures\Command\CompleteTaskCommand;
 
 class QueueingCommandBusTest extends \PHPUnit_Framework_TestCase
 {
@@ -31,7 +31,7 @@ public function setup()
 
     public function testInnerCommandBusReceivesCommand()
     {
-        $command = new TaskAddedCommand();
+        $command = new AddTaskCommand();
 
         $this->innerCommandBus
             ->shouldReceive('execute')
@@ -47,8 +47,8 @@ public function testInnerCommandBusReceivesCommand()
 
     public function testCommandsAreQueuedIfAnotherCommandIsBeingExecuted()
     {
-        $firstCommand = new TaskAddedCommand();
-        $secondCommand = new TaskCompletedCommand();
+        $firstCommand = new AddTaskCommand();
+        $secondCommand = new CompleteTaskCommand();
         $secondCommandDispatched = false;
 
         $this->innerCommandBus

tests/Tactician/Tests/Fixtures/Command/TaskAddedCommand.php → tests/Tactician/Tests/Fixtures/Command/AddTaskCommand.php

@@ -2,6 +2,6 @@
 
 namespace Tactician\Tests\Fixtures\Command;
 
-class TaskAddedCommand
+class AddTaskCommand
 {
 }

tests/Tactician/Tests/Fixtures/Command/TaskCompletedCommand.php → tests/Tactician/Tests/Fixtures/Command/CompleteTaskCommand.php

@@ -2,6 +2,6 @@
 
 namespace Tactician\Tests\Fixtures\Command;
 
-class TaskCompletedCommand
+class CompleteTaskCommand
 {
 }

tests/Tactician/Tests/Fixtures/Handler/TaskCompletedHandler.php → tests/Tactician/Tests/Fixtures/Handler/ConcreteMethodsHandler.php

@@ -3,9 +3,10 @@
 namespace Tactician\Tests\Fixtures\Handler;
 
 /**
- *  
+ * Sample handler that has all commands specified as individual methods, rather
+ * than using magic methods like __call or __invoke.
  */
-class TaskCompletedHandler
+class ConcreteMethodsHandler
 {
     public function handleTaskCompletedCommand($command)
     {

tests/Tactician/Tests/Handler/Locator/InMemoryLocatorTest.php

@@ -3,7 +3,7 @@
 namespace Tactician\Tests\Handler\Locator;
 
 use Tactician\Handler\Locator\InMemoryLocator;
-use Tactician\Tests\Fixtures\Command\TaskCompletedCommand;
+use Tactician\Tests\Fixtures\Command\CompleteTaskCommand;
 
 class InMemoryLocatorTest extends \PHPUnit_Framework_TestCase
 {
@@ -21,11 +21,11 @@ public function testHandlerIsReturnedForSpecificClass()
     {
         $handler = new \stdClass();
 
-        $this->inMemoryLocator->addHandler($handler, TaskCompletedCommand::class);
+        $this->inMemoryLocator->addHandler($handler, CompleteTaskCommand::class);
 
         $this->assertSame(
             $handler,
-            $this->inMemoryLocator->getHandlerForCommand(new TaskCompletedCommand())
+            $this->inMemoryLocator->getHandlerForCommand(new CompleteTaskCommand())
         );
     }
 
@@ -34,6 +34,6 @@ public function testHandlerIsReturnedForSpecificClass()
      */
     public function testHandlerMissing()
     {
-        $this->inMemoryLocator->getHandlerForCommand(new TaskCompletedCommand());
+        $this->inMemoryLocator->getHandlerForCommand(new CompleteTaskCommand());
     }
 }

tests/Tactician/Tests/Handler/MethodNameInflector/HandleClassNameInflectorTest.php

@@ -2,8 +2,8 @@
 namespace Tactician\Tests\Handler\MethodNameInflector;
 
 use Tactician\Handler\MethodNameInflector\HandleClassNameInflector;
-use Tactician\Tests\Fixtures\Command\TaskCompletedCommand;
-use Tactician\Tests\Fixtures\Handler\TaskCompletedHandler;
+use Tactician\Tests\Fixtures\Command\CompleteTaskCommand;
+use Tactician\Tests\Fixtures\Handler\ConcreteMethodsHandler;
 use stdClass;
 
 class HandleClassNameInflectorTest extends \PHPUnit_Framework_TestCase
@@ -21,7 +21,7 @@ class HandleClassNameInflectorTest extends \PHPUnit_Framework_TestCase
     protected function setUp()
     {
         $this->inflector = new HandleClassNameInflector();
-        $this->handler = new TaskCompletedHandler();
+        $this->handler = new ConcreteMethodsHandler();
     }
 
     public function testHandlesClassesWithoutNamespace()
@@ -36,10 +36,10 @@ public function testHandlesClassesWithoutNamespace()
 
     public function testHandlesNamespacedClasses()
     {
-        $command = new TaskCompletedCommand();
+        $command = new CompleteTaskCommand();
 
         $this->assertEquals(
-            'handleTaskCompletedCommand',
+            'handleCompleteTaskCommand',
             $this->inflector->inflect($command, $this->mockHandler)
         );
     }

tests/Tactician/Tests/Handler/MethodNameInflector/InvokeInflectorTest.php

@@ -2,8 +2,8 @@
 namespace Tactician\Tests\Handler\MethodNameInflector;
 
 use Tactician\Handler\MethodNameInflector\InvokeInflector;
-use Tactician\Tests\Fixtures\Command\TaskCompletedCommand;
-use Tactician\Tests\Fixtures\Handler\TaskCompletedHandler;
+use Tactician\Tests\Fixtures\Command\CompleteTaskCommand;
+use Tactician\Tests\Fixtures\Handler\ConcreteMethodsHandler;
 
 /**
  * Best. Test. Ever.
@@ -16,7 +16,7 @@ public function testReturnsInvokeMagicMethod()
 
         $this->assertEquals(
             '__invoke',
-            $inflector->inflect(new TaskCompletedCommand(), new TaskCompletedHandler())
+            $inflector->inflect(new CompleteTaskCommand(), new ConcreteMethodsHandler())
         );
     }
 }