{kirkstone} Fix ROS packages to use arch-specific directory for installing libraries #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of the ROS packages are hardcoded to install to /usr/lib. This
causes problems for 64-bit machine that expect the libraries to be in
/usr/lib64.
Patch the destination in CMakeFiles.txt to use ${CMAKE_INSTALL_LIBDIR}
and set the PYTHON_INSTALL_DIR to a relative path using ${baselib}.
Signed-off-by: Rob Woolley <[email protected]>
This ensures that libyaml uses the architecture specific installation directories for libraries on 64-bit platform. Signed-off-by: Rob Woolley <[email protected]>
…IP_RECIPE Signed-off-by: Rob Woolley <[email protected]>
robwoolley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake files in the ROS packages have "lib" hardcoded as the destination. We can set the right destination in Install() as well as set the Python site-packages directory to be dynamic based on whether being built for 32-bit or 64-bit platforms.