Kirkstone fixes #1009
Kirkstone fixes #1009
Conversation
Signed-off-by: Tim Orling <[email protected]>
Upstream is inactive, but it is a simple enough patch to switch from distutils.core to setuptools so we can inherit setuptools3 and silence the distutils3 deprecation warning. Signed-off-by: Tim Orling <[email protected]>
setup.py actually tests for setuptools first and falls back on distutils. Silence the distutils3 deprecation warning by inheriting setuptools3 instead. Signed-off-by: Tim Orling <[email protected]>
Replace deprecated distutils3-base with setuptools3-base Signed-off-by: Tim Orling <[email protected]>
|
Not asking for this to be merged, but just FYI: https://github.com/moto-timo/meta-ros/tree/superflore-kirkstone-2022-04 |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/announcing-the-completion-of-meta-ros-milestone-17/25933/3 |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-01-19/29423/7 |
|
I pulled your kirkstone-fixes branch, and I get the following error when running it: I made a PR that is the same as yours, except more up-to-date and is based off the langdale branch as opposed to the honister one. It is PR #1051, feel free to check it out |
|
Thanks, @moto-timo I have pulled in your fixes into the kirkstone commit series I am getting ready to push before Monday. |
This series mostly fixes deprecated distutils usage, but also changes the release compatibility from 'honister' to 'kirkstone'
a0e7adc ros_catkin.bbclass: inherit setuptools3-base
876a5e2 python3-pydot: inherit setuptools3
d0a89e1 python3-empy: patch to use setuptools3
f2d275d ros-distro.conf: ROS_OE_RELEASE_SERIES -> kirkstone