Remove os prefix from consecutive build error. #51
Conversation
allenh1
force-pushed
the
consecutive-run-error-50
branch
from
37bc92e
to
cb951ce
Compare
superflore/generators/bitbake/run.py
Outdated
| link_existing_files(args.ros_distro) | ||
| """ | ||
| try: | ||
| link_existing_files(args.ros_distro) |
There was a problem hiding this comment.
This looks to be linking args.ros_distro, but the exception removes all active distros?
There was a problem hiding this comment.
Related do we really need to symlink? Why don't we simple change the working directory/pass the repository location as an argument?
There was a problem hiding this comment.
This looks to be linking args.ros_distro, but the exception removes all active distros?
The function attempts to remove all distros, and has a try catch around it that just passes if it fails to remove the link.
Related do we really need to symlink? Why don't we simple change the working directory/pass the repository location as an argument?
I think that's a much better solution. I'm more partial to that behavior. Could you propose a format for that flag?
There was a problem hiding this comment.
This goes with the ability to reuse an exisiting repo. I'd suggest --output-repository-path as an argument. Where if it's unset it will use a temporary directory. (If it uses a temporary directory it should delete it at the end after opening the PR) There could be a flag to prevent the cleanup. and logic to prevent you from running without a PR or preventing cleanup.
allenh1
force-pushed
the
consecutive-run-error-50
branch
2 times, most recently
from
7b82c8e
to
56dac04
Compare
|
@tfoote I added the |
|
Adding the output repository path is good. But I'd like to go one step further and not create the symlinks and just work in the repositories directory. |
allenh1
force-pushed
the
consecutive-run-error-50
branch
from
89cbc9d
to
a3b5a14
Compare
|
@tfoote I've removed the sym-link logic, and just rebased on top of master. |
* Switch to use util functions. * Use the generate_installers function from superflore.generate_installers * Linting * Change the ros_meta class to be RosMeta, as well as changed the inheritance to be a member of the class (see #52). * Removed the sym-linked structure to behave more like the Gentoo generator (see #51). * Removed a commented line from the ebuild logic copypasta, changed the print format slightly for the exception output after a failed pr, and called the file_pr function. * Add temporary file manager code, as suggested by @tfoote. * Switch to utils print functions for TempfileManager output. * Use tempfile manager to clean up temp directories at exit. * Linting. * Remove hard-coded org and repo from RepoInstance call. * Reorder import statements. * Ok, that's pretty cool. * Apply new TempfileManager usage to OpenEmbedded logic. * OpenEmbedded generation is now running. ToDo: automatically clean up the tar files. * Files were not generating in the directory, but are now. * Fixed argument mapping for ebuild generator.
* Switch to use util functions. * Use the generate_installers function from superflore.generate_installers * Linting * Change the ros_meta class to be RosMeta, as well as changed the inheritance to be a member of the class (see ros-infrastructure#52). * Removed the sym-linked structure to behave more like the Gentoo generator (see ros-infrastructure#51). * Removed a commented line from the ebuild logic copypasta, changed the print format slightly for the exception output after a failed pr, and called the file_pr function. * Add temporary file manager code, as suggested by @tfoote. * Switch to utils print functions for TempfileManager output. * Use tempfile manager to clean up temp directories at exit. * Linting. * Remove hard-coded org and repo from RepoInstance call. * Reorder import statements. * Ok, that's pretty cool. * Apply new TempfileManager usage to OpenEmbedded logic. * OpenEmbedded generation is now running. ToDo: automatically clean up the tar files. * Files were not generating in the directory, but are now. * Fixed argument mapping for ebuild generator.
Fixes traceback for #50
Current behavior just removes the symlinks. I should adapt this to remove the existing tmp directory as well.
connects to #50
connects to #32