Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust PR message stating how superflore was executed #214

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

andre-rosa
Copy link
Contributor

  • In fact, it's not possible to reproduce the PR fully by running again
    as superflore makes use of remote metadata. So state that instead of
    reproducing the PR, it'll list the command used originally.

Fixes #213 .

@andre-rosa
Copy link
Contributor Author

@allenh1 << Ptal

@allenh1
Copy link
Collaborator

allenh1 commented Jun 28, 2019

@andre-rosa I am going to let @tfoote decide on this.

I was okay with the way it was worded before, but you make a good point here. Tully is definitely better at wording things than I, so I'd like his input before merging this.

@andre-rosa
Copy link
Contributor Author

@allenh1 @tfoote << Ptal :)

tests/test_utils.py Outdated Show resolved Hide resolved
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change that it's not reproducible makes sense. But I agree with @allenh1 that issuing is not clear to the user.

tests/test_utils.py Outdated Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
superflore/utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@allenh1 allenh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andre-rosa very small fix left

tests/test_utils.py Outdated Show resolved Hide resolved
superflore/utils.py Outdated Show resolved Hide resolved
  - In fact, it's not possible to reproduce the PR fully by running again
    as superflore makes use of remote metadata. So state that instead of
    reproducing the PR, it'll list the command used originally.
Copy link
Collaborator

@allenh1 allenh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@allenh1 allenh1 merged commit 52b8d3b into ros-infrastructure:master Jul 23, 2019
@andre-rosa andre-rosa deleted the adjust_PR_message branch July 30, 2019 05:38
zffgithub pushed a commit to zffgithub/superflore that referenced this pull request Apr 11, 2023
…ture#214)

- In fact, it's not possible to reproduce the PR fully by running again
    as superflore makes use of remote metadata. So state that instead of
    reproducing the PR, it'll list the command used originally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR message stating how superflore was executed needs adjustment
4 participants