Pass distro to generate_installer #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OpenEmbedded generation will need information from distro from
run.py, so allow run.py to get_distro() just once and pass it to
generate_installer(), like it's done for regenerate_installer().
allenh1
previously approved these changes
Apr 18, 2019
tfoote
requested changes
Apr 18, 2019
Co-Authored-By: andre-rosa <[email protected]>
tfoote
approved these changes
Apr 18, 2019
allenh1
approved these changes
Apr 18, 2019
zffgithub
pushed a commit
to zffgithub/superflore
that referenced
this pull request
Apr 11, 2023
* Pass distro to generate_installer
* OpenEmbedded generation will need information from distro from
run.py, so allow run.py to get_distro() just once and pass it to
generate_installer(), like it's done for regenerate_installer().
* Use proxy instead of private attribute
Co-Authored-By: andre-rosa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run.py, so allow run.py to get_distro() just once and pass it to
generate_installer(), like it's done for regenerate_installer().