-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI #125
Conversation
I'd suggest keeping trying going forward onto xenial. Note that python 3.4 is very old for xenial. If it works locally, I'd suggest finding a way to disable the pull test only on travis, maybe a command line argument etc. |
These issues seem to be in the travis setup before the job even starts. I'd suggest looking through some of the travis tutorials and seeing if there are some basic settings to bring across for docker based testing. |
@tfoote I used the |
Ok, so, some random failures later, and things are ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, it would be good to figure out why the pull test fails. because clearly it can pull that in other parts of the testing.
* use the exclude flag to skip the pull test.
@tfoote This is the branch I'll use to fix the CI.
Seems that disabling the pull test does the trick. But the reason I have to is still beyond me.