Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #125

Merged
merged 5 commits into from
Jan 26, 2018
Merged

Fix CI #125

merged 5 commits into from
Jan 26, 2018

Conversation

allenh1
Copy link
Collaborator

@allenh1 allenh1 commented Jan 24, 2018

@tfoote This is the branch I'll use to fix the CI.

Seems that disabling the pull test does the trick. But the reason I have to is still beyond me.

@tfoote
Copy link
Member

tfoote commented Jan 24, 2018

I'd suggest keeping trying going forward onto xenial. Note that python 3.4 is very old for xenial.

If it works locally, I'd suggest finding a way to disable the pull test only on travis, maybe a command line argument etc.

@tfoote
Copy link
Member

tfoote commented Jan 24, 2018

These issues seem to be in the travis setup before the job even starts. I'd suggest looking through some of the travis tutorials and seeing if there are some basic settings to bring across for docker based testing.

@allenh1
Copy link
Collaborator Author

allenh1 commented Jan 26, 2018

@tfoote I used the --exclude flag to skip past the test for test_pull. I'm pretty sure it should work now.

@allenh1
Copy link
Collaborator Author

allenh1 commented Jan 26, 2018

Ok, so, some random failures later, and things are ok.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, it would be good to figure out why the pull test fails. because clearly it can pull that in other parts of the testing.

@allenh1 allenh1 merged commit 8da764e into master Jan 26, 2018
@allenh1 allenh1 deleted the fix-ci branch January 28, 2018 01:10
zffgithub pushed a commit to zffgithub/superflore that referenced this pull request Apr 11, 2023
* use the exclude flag to skip the pull test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants