Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use allenh1/ros_gentoo_base for Docker #122

Merged
merged 3 commits into from
Jan 27, 2018
Merged

Conversation

allenh1
Copy link
Collaborator

@allenh1 allenh1 commented Jan 23, 2018

It occurred to me that we really don't need to have two docker images anymore, since the other can just be pulled down when needed.

As such, this simply removes the repoman_docker image, as it's a subset of the Dockerfile used to generate allenh1/ros_gentoo_base.

@tfoote
Copy link
Member

tfoote commented Jan 23, 2018

It does seem to make sense to collapse those two images together. Might it make sense however to move that image here? Otherwise you'll end up with cross coupling if you want to fork this repo, and then have to fork that image and then redirect to use the alternative version. Versus if it was here it could build it in the case that it's not already hosted.

@allenh1
Copy link
Collaborator Author

allenh1 commented Jan 23, 2018

Versus if it was here it could build it in the case that it's not already hosted.

That's a good idea. Maybe it should be in its own repo and used as a git submodule? I feel that it doesn't really belong in either repo.

@tfoote
Copy link
Member

tfoote commented Jan 23, 2018

Submodules I've found are often a problem but might work in this case. Though I think that you actually have different use cases. One is the boostrap tool for superflore, and one is a generic base image for users to be able to build on top of. They may be very similar but I don't know that they necessarily will want to maintain all changes on both sides so maintaining them in parallel might make sense.

PS where's the source for that image. I couldn't find it in a quick search.

@allenh1
Copy link
Collaborator Author

allenh1 commented Jan 23, 2018

Though I think that you actually have different use cases.

Maybe the solution would then be to close this PR and to host the repoman_docker image?

PS where's the source for that image. I couldn't find it in a quick search.

You can find the source for it in the ROS-Overlay repo.

tfoote
tfoote previously approved these changes Jan 26, 2018
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, opened #126 to follow up o dockerfile hosting

@allenh1 allenh1 merged commit d7e40b9 into master Jan 27, 2018
@allenh1 allenh1 deleted the use-gentoo-base-docker branch January 27, 2018 01:55
zffgithub pushed a commit to zffgithub/superflore that referenced this pull request Apr 11, 2023
* Pull the docker image we use for testing instead of building a fresh one (as this Dockerfile is a subset of the other).

* Remove repoman_docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants