Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for ros-infrastructure/superflore#117. #118

Merged
merged 2 commits into from
Jan 14, 2018

Conversation

allenh1
Copy link
Collaborator

@allenh1 allenh1 commented Jan 13, 2018

Add a test to prevent this from happening in the future.

connects to #117.

@allenh1
Copy link
Collaborator Author

allenh1 commented Jan 14, 2018

@tfoote do you think this merits a patch release? This is not so great.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine. It seems odd to pad whitespace on between the parentheses but if that's their standard, that's what we need to do. +1 for adding the test

I don't know what the ramifications are for this change to judge the need for a patch release. Though at this point things are still evolving quick enough that I suspect that working from source is to be expected.

@allenh1 allenh1 merged commit 1165027 into master Jan 14, 2018
@allenh1 allenh1 deleted the fix-multi-license-ebuilds branch January 14, 2018 03:13
@allenh1
Copy link
Collaborator Author

allenh1 commented Jan 14, 2018

The change looks fine. It seems odd to pad whitespace on between the parentheses but if that's their standard, that's what we need to do.

It's not my favorite style either. There's likely some really strange parsing reason for it, but I wouldn't really know.

I don't know what the ramifications are for this change to judge the need for a patch release.

The only reason I suggest this is so that I don't get any PR's that might have this bug in them. Portage refuses to build an ebuild that is made with that kind of license line (making this quite annoying). I discovered this when I was building ros-lunar/desktop_full from scratch on my Gentoo system. All is now working (at least for lunar) with this patch, though.

All of this said, I'm decently sure I'm going to be the only one running superflore for the time being, so I suppose it's not very important that we push a patch version for it.

zffgithub pushed a commit to zffgithub/superflore that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants