Fix an issue with the dockerfile. #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfoote
requested changes
Dec 19, 2017
There was a problem hiding this comment.
The extra commands look fine.
However, It's probably better to keep this as one layer in the dockerfile. For cleaner reading use \ line wrapping. A single layer will make sure that the syncs and emerge don't get cached improperly. And fewer layers means smaller images in general.
|
@tfoote I was kind of expecting that. Fixed. |
tfoote
approved these changes
Dec 19, 2017
zffgithub
pushed a commit
to zffgithub/superflore
that referenced
this pull request
Apr 11, 2023
* Fix an issue with the dockerfile. * Move commands to a single line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds a few commands to the
Dockerfilethat cause problems with (newer) versions of portage.