generate_installers() may record a failure in gen_pkg_func() as success #186
Comments
andre-rosa
added a commit
to lgsvl/superflore
that referenced
this issue
May 8, 2019
generate_installers() didn't consider a few gen_pkg_func() failure
situations like:
- InvalidPackage:
The manifest contains invalid XML: syntax error: line 1, column 0
!!!! 61.7%: Failed to generate installer for package 'qb_chain'!
- NoPkgXml: Could not fetch pkg!
Those are signaled by gen_pkg_func by returning no installer (None)
and no missing dependencies ([]).
Whenever gen_pkg_func() returns no installer, it must be an error except
when we want to preserve_existing.
Fixes ros-infrastructure#186 .
andre-rosa
added a commit
to lgsvl/superflore
that referenced
this issue
May 20, 2019
generate_installers() didn't consider a few gen_pkg_func() failure
situations like:
- InvalidPackage:
The manifest contains invalid XML: syntax error: line 1, column 0
!!!! 61.7%: Failed to generate installer for package 'qb_chain'!
- NoPkgXml: Could not fetch pkg!
Those are signaled by gen_pkg_func by returning no installer (None)
and no missing dependencies ([]).
Whenever gen_pkg_func() returns no installer, it must be an error except
when we want to preserve_existing.
Fixes ros-infrastructure#186 .
allenh1
pushed a commit
that referenced
this issue
May 22, 2019
) generate_installers() didn't consider a few gen_pkg_func() failure situations like: - InvalidPackage: The manifest contains invalid XML: syntax error: line 1, column 0 !!!! 61.7%: Failed to generate installer for package 'qb_chain'! - NoPkgXml: Could not fetch pkg! Those are signaled by gen_pkg_func by returning no installer (None) and no missing dependencies ([]). Whenever gen_pkg_func() returns no installer, it must be an error except when we want to preserve_existing. Fixes #186 .
zffgithub
pushed a commit
to zffgithub/superflore
that referenced
this issue
Apr 11, 2023
…os-infrastructure#187) generate_installers() didn't consider a few gen_pkg_func() failure situations like: - InvalidPackage: The manifest contains invalid XML: syntax error: line 1, column 0 !!!! 61.7%: Failed to generate installer for package 'qb_chain'! - NoPkgXml: Could not fetch pkg! Those are signaled by gen_pkg_func by returning no installer (None) and no missing dependencies ([]). Whenever gen_pkg_func() returns no installer, it must be an error except when we want to preserve_existing. Fixes ros-infrastructure#186 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
generate_installers() doesn't consider a few gen_pkg_func() failure situations like:
InvalidPackage: The manifest contains invalid XML: syntax error: line 1, column 0!!!! 61.7%: Failed to generate installer for package 'qb_chain'!
NoPkgXml: Could not fetch pkg!Whenever gen_pkg_func() doesn't return an installer, it must be an error except when we want to preserve_existing , therefore make it record a failure when no installer is returned and we don't want to preserve_existing .
The text was updated successfully, but these errors were encountered: