[TPython] Make TPython thread-safe #16427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
force-pushed
the
tpython_gil
branch
from
2dcb3f7
to
24d6c3e
Compare
Test Results 13 files 13 suites 3d 4h 25m 34s ⏱️ Results for commit b371183. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
tpython_gil
branch
from
3c172a2
to
a9ad23a
Compare
guitargeek
force-pushed
the
tpython_gil
branch
from
e0d6bce
to
a0a8c9d
Compare
|
I have successfully made the following ROOT macro work: void task1(int i)
{
std::stringstream code;
code << "print(" << i << ")";
TPython::Exec(code.str().c_str());
}
void repro()
{
int nThreads = 1000;
std::vector<std::thread> threads;
for (int i = 0; i < nThreads; i++) {
threads.emplace_back(task1, i);
}
for (int i = 0; i < threads.size(); i++) {
threads[i].join();
}
}I'll turn this into a unit test tomorrow. |
guitargeek
changed the title
guitargeek
force-pushed
the
tpython_gil
branch
from
a0a8c9d
to
c87d0a8
Compare
guitargeek
force-pushed
the
tpython_gil
branch
from
c87d0a8
to
23e9fd8
Compare
guitargeek
added a commit
to guitargeek/CPyCppyy
that referenced
this pull request
Sep 17, 2024
No static `gPythonizations` variable to avoid static initialization order fiasco. This avoids some crashes when using `TPython` in compiled code. This is necessary to make a newly suggested TPython multithreading unit test work: root-project/root#16427
guitargeek
force-pushed
the
tpython_gil
branch
2 times, most recently
from
b7041b6
to
aa5ada6
Compare
Analogous to commit 2b64c0f, where the same was done in the CPyCppyy API.
No static `gPythonizations` variable to avoid static initialization order fiasco. This avoids some crashes when using `TPython` in compiled code.
The PyGILState_Ensure() and PyGILState_Release() functions should be used as part of idiomatic code that calls Python from a C/C++ thread: https://docs.python.org/3/c-api/init.html#non-python-created-threads Also prevent concurrently initializing the Python interpreter by putting a lock in the private `TPython::Initialise()` function. This addresses the following issue reported by the Gaudi framework developers: https://gitlab.cern.ch/gaudi/Gaudi/-/issues/329#note_8433064
One would need to acquire the GIL at destruction time to make this work in multithreading setups.
guitargeek
force-pushed
the
tpython_gil
branch
from
aa5ada6
to
b371183
Compare
guitargeek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PyGILState_Ensure() and PyGILState_Release() functions should be used as part of idiomatic code that calls Python from a C/C++ thread:
https://docs.python.org/3/c-api/init.html#non-python-created-threads
This addresses the following issue reported by the Gaudi framework developers:
https://gitlab.cern.ch/gaudi/Gaudi/-/issues/329#note_8433064