Fix spaces occupancy in TTF::PrepareString #15971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linev
approved these changes
Jul 2, 2024
…icated in two locations. This commit refactors it to improve code reusability and maintainability.
Test Results 13 files 13 suites 2d 20h 52m 56s ⏱️ Results for commit 00a337c. ♻️ This comment has been updated with latest results. |
linev
approved these changes
Jul 3, 2024
This was referenced Jul 3, 2024
silverweed
pushed a commit
to silverweed/root
that referenced
this pull request
Aug 19, 2024
* Fix spaces occupancy in TTF::PrepareString * The code responsible for computing the Trailing Blanks Width was duplicated in two locations. This commit refactors it to improve code reusability and maintainability. * stressGraphics reference files need a minor adjustement * Move fgTBlankW initialisation * add a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in GitHub issue #15948, there was a problem in the TTF::PrepareString function where the length of trailing white spaces was not being computed correctly. This issue led to inaccuracies in text rendering, as the function failed to account for the correct width of trailing white spaces in the provided strings.