Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the environment (dev/prod) a parameter #170

Closed
w00tedness opened this issue Jun 16, 2017 · 1 comment
Closed

make the environment (dev/prod) a parameter #170

w00tedness opened this issue Jun 16, 2017 · 1 comment
Labels
enhancement Planned feature help wanted

Comments

@w00tedness
Copy link
Contributor

useful for testing
@alallier alallier added the enhancement Planned feature label Jun 16, 2017
@kethinov
Copy link
Member

I coulda swore there is a way to do this with Express already but I don't see anything obvious with a bit of poking around. Before we go adding a param for this, check to make sure there isn't a simple way beyond NODE_ENV to this first to avoid reinventing the wheel. Otherwise, have at it.

lyomr added a commit to lyomr/roosevelt that referenced this issue Jun 19, 2017
@lyomr
make the environment (dev/prod) a parameter rooseveltframework#170
30a44fd
@lyomr lyomr mentioned this issue Jun 20, 2017
Merged
lyomr added a commit to lyomr/roosevelt that referenced this issue Jun 20, 2017
@lyomr
constructor param for devProd fixed rooseveltframework#170
491b1c6
lyomr added a commit to lyomr/roosevelt that referenced this issue Jun 20, 2017
@lyomr
linting rooseveltframework#170
1308fc4
lyomr added a commit to lyomr/roosevelt that referenced this issue Jun 20, 2017
@lyomr
ReadMe documentation rooseveltframework#170
1fae9ea
lyomr added a commit to lyomr/roosevelt that referenced this issue Jun 20, 2017
@lyomr
make nodeEnv default to process.env.NODE_ENV if params or RooseveltCo…
820cc6f 
…nfig not set && changes to README rooseveltframework#170
lyomr added a commit to lyomr/roosevelt that referenced this issue Jun 20, 2017
@lyomr
match the express values: development and production for nodeEnv roos…
22967d9 
…eveltframework#170
kethinov added a commit that referenced this issue Jun 20, 2017
@kethinov
Merge pull request #173 from lyomr/oumar
b2c462c 
Make the environment (dev/prod) a parameter #170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Planned feature help wanted
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kethinov @w00tedness @alallier