Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move partial sync to app.tsx and use it to pass loading state to detail view #130

Merged
merged 11 commits into from
May 10, 2022
Merged

feat: move partial sync to app.tsx and use it to pass loading state to detail view #130

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
12fd838
feat: move partial sync to app.tsx and use it to pass loading state t…
grgbkr May 9, 2022
3825f1d
feat: hookup partial sync status to detail loading ui
grgbkr May 10, 2022
18e7fac
only show loading for description if description null and isLoading. …
grgbkr May 10, 2022
f3a2c16
handler naming
grgbkr May 10, 2022
40f383b
fixup backing view of detail
grgbkr May 10, 2022
a786cde
clear iss to close detail
grgbkr May 10, 2022
37ed4a1
put back in debug logging for partial sync
grgbkr May 10, 2022
6f2e5f1
left nav tweak
grgbkr May 10, 2022
64283d8
remove unused dep
grgbkr May 10, 2022
16e9e2f
fix build
grgbkr May 10, 2022
4a4f9fe
fix left nav links
grgbkr May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix build
  • Loading branch information
@grgbkr
grgbkr committed May 10, 2022
commit 16e9e2f4006fa90df78647b674b8ee120110fd29
4 changes: 0 additions & 4 deletions frontend/left-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import SearchBox from "./searchbox";
import IssueModal from "./issue-modal";
import ReactLogo from "./assets/images/logo.svg";
import type { Description, Issue } from "./issue";
import { useRouter } from "next/router";
import { useQueryState } from "next-usequerystate";
import AboutModal from "./about-modal";

Expand All @@ -32,9 +31,6 @@ const LeftMenu = ({ menuVisible, onCloseMenu, onCreateIssue }: Props) => {
const [issueModalVisible, setIssueModalVisible] = useState(false);
const [aboutModalVisible, setAboutModalVisible] = useState(true);

const router = useRouter();
const { id } = router.query;

const classes = classnames(
"absolute lg:static inset-0 lg:relative lg:translate-x-0 flex flex-col flex-shrink-0 w-56 font-sans text-sm border-r lg:shadow-none justify-items-start bg-gray-500 border-gray-400 text-white bg-opacity-1",
{
Expand Down