Image preprocessing block (flip, rotate, resize) #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilyGavrilenko
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
yeldarby,
probicheaux and
hansent
as code owners
| } | ||
| }, | ||
| ) | ||
| flip_type: Union[str, WorkflowParameterSelector(kind=[STRING_KIND]), Literal["vertical", "horizontal", "both"]] = Field( # type: ignore |
There was a problem hiding this comment.
let's remove str here
PawelPeczek-Roboflow
previously approved these changes
Sep 26, 2024
PawelPeczek-Roboflow
previously approved these changes
Sep 26, 2024
grzegorz-roboflow
requested changes
Sep 26, 2024
| np_image: np.ndarray, width: Optional[int], height: Optional[int] | ||
| ) -> np.ndarray: | ||
| if width is None and height is None: | ||
| return np_image |
There was a problem hiding this comment.
Suggested change
| return np_image | |
| return np_image.copy() |
We should return copy of the image to be consistent with remainder of this method where copy is returned
|
|
||
| def apply_rotate_image(np_image: np.ndarray, rotation_degrees: Optional[int]): | ||
| if rotation_degrees is None or rotation_degrees == 0: | ||
| return np_image |
There was a problem hiding this comment.
Suggested change
| return np_image | |
| return np_image.copy() |
| def apply_rotate_image(np_image: np.ndarray, rotation_degrees: Optional[int]): | ||
| if rotation_degrees is None or rotation_degrees == 0: | ||
| return np_image | ||
| else: |
There was a problem hiding this comment.
we already returned, else is not required (can save one indent level)
grzegorz-roboflow
previously approved these changes
Sep 26, 2024
…ence into image_preprocessing_block
PawelPeczek-Roboflow
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a block that supports resizing, flipping, and rotating
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
UI editor & with tests
Any specific deployment considerations
n/a
Docs
n/a