-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe workflow intefrace #644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same can be achieved having schemas of blocks on the UI end - why secondary request to backend to run post-processing of schemas needed?
A customer requested an API endpoint to call to get the schema for the workflow response (slack thread). Will be used for integration with their downstream pipelines |
ok then - let's mark it to be released in |
taking that and preparing for rel |
@@ -956,6 +960,41 @@ async def infer_lmm( | |||
|
|||
if not DISABLE_WORKFLOW_ENDPOINTS: | |||
|
|||
@app.post( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that needs to be added into hosted API routing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add it here like the other ones: https://github.com/roboflow/roboflow-infra/blob/1e58b097dc081a18851588a253d18ac3e4539b1c/aws/serverless/modules/containerlambda/main.tf#L128-L144
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EmilyGavrilenko is the customer requesting this running on hosted API or dedicates/local?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's hosted most likely given Nick comment
I posted this comment not to forget
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regardless - this is potentially useful feature for preview in UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
infra PR here: https://github.com/roboflow/roboflow-infra/pull/334
Added
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm tested locally
we only need this for explicit spec? i.e. not able to get it for name workflow via workflow url?
|
like I have to post the workflow spec, but I can't post hte workflow url and have it looked up via API like I can for running it? |
still do not understand - I feel like both are possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reapproving after fixing block names
Description
Adding capability to describe workflow interface - both inputs and outputs regarding types of data:
The following workflow:
will return:
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs