Fix Detection Offset Bug #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickHerrig
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
yeldarby,
probicheaux and
hansent
as code owners
NickHerrig
changed the title
PawelPeczek-Roboflow
approved these changes
Aug 30, 2024
PawelPeczek-Roboflow
deleted the
nick/bug-fix/detection-offset-null-images
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the detection offset block, one could set values larger than the image demensions and would result in over offset and null values. This can also be seen when detections are near the edge of the images.
This PR fixes the detection offset block to the image demensions provided.
detection_offset_bug_fix.mp4
Type of change
How has this change been tested, please provide a test case or example of how you tested the change?
New unit test which tests extremely large offsets.