Abstract sqlite3 wrapper in usage collector sqlite queue #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nference.core.utils.sqlite_wrapper
grzegorz-roboflow
requested review from
PawelPeczek-Roboflow,
yeldarby,
probicheaux and
hansent
as code owners
| self._columns = {**columns, **{"id": "INTEGER PRIMARY KEY"}} | ||
|
|
||
| if not connection: | ||
| if not os.path.exists(os.path.dirname(db_file_path)): |
There was a problem hiding this comment.
[minor] os.makedirs(..., exist_ok=True) should get the job done
PawelPeczek-Roboflow
previously approved these changes
Aug 29, 2024
| self, | ||
| values: Dict[ColName, ColValue], | ||
| connection: Optional[sqlite3.Connection] = None, | ||
| ): |
There was a problem hiding this comment.
could u give return types annotations?
There was a problem hiding this comment.
Done, this method should not return, modified a bit to re-rise instead.
PawelPeczek-Roboflow
approved these changes
Aug 29, 2024
grzegorz-roboflow
deleted the
abstract-sqlite3-wrapper-in-usage-collector-sqlite-queue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract sqlite3 wrapper in usage collector sqlite queue; preparation for storing plan details in sqlite cache
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Added unit tests covering new functionality
Any specific deployment considerations
N/A
Docs
N/A