Video metadata in workflows
#590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzegorz-roboflow
requested changes
Aug 21, 2024
| @@ -1083,7 +1092,8 @@ def decode_video_frame_to_buffer( | |||
| buffer: Queue, | |||
| decoding_pace_monitor: sv.FPSMonitor, | |||
| source_id: Optional[int], | |||
| fps: float = 0, | |||
| fps: Optional[float] = 0, | |||
There was a problem hiding this comment.
Maybe we should make it None as default since it`s marked as optional?
| @@ -140,6 +161,65 @@ def _assembly_input_image( | |||
| ) | |||
|
|
|||
|
|
|||
| def assembly_video_metadata( | |||
There was a problem hiding this comment.
assembly is noun, are we preferring verbs for method names? (i.e. assemble instead of assembly)
| return result | ||
|
|
||
|
|
||
| def _assembly_video_metadata( |
There was a problem hiding this comment.
we probably prefer assemble instead of assembly in method name
PawelPeczek-Roboflow
requested review from
yeldarby,
probicheaux and
hansent
as code owners
grzegorz-roboflow
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I try to add video metadata to
workflowsto make it possible for stateful stream- / video- processing blocks to operate.We have two options basically:
WorkflowImageinputThe latter is more elegant imo, does not break bckw compatibility and is also a proof that adding new types of inputs (batch of text data to process by LMM model) will be easily possible.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
YOUR_ANSWER
Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs