Allow configurable "labeling batch prefix" on Roboflow Dataset Upload block. #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickHerrig
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
yeldarby,
probicheaux and
hansent
as code owners
PawelPeczek-Roboflow
previously approved these changes
Aug 20, 2024
|
We have a request to make predictions optional - would you be able to take it? |
|
@PawelPeczek-Roboflow Yeah, I can take a look at that. |
|
looks, ok - gimme sec to test it out |
|
Ok, added tests LGTM |
PawelPeczek-Roboflow
approved these changes
Aug 21, 2024
grzegorz-roboflow
approved these changes
Aug 21, 2024
PawelPeczek-Roboflow
deleted the
nick/feat/fix-upload-block-batch-prefix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to configure a workflow parameter to be passed in to set the labeling batch prefix on the Roboflow Dataset Upload block. Previously, manually setting this field to
$input.batch_namecould cause the execution engine to raise a 500 error.Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
I've tested this locally through running the inference server and uploading an image with the batch-prefix.