Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security issues with landing page #584

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

PawelPeczek-Roboflow
Copy link
Collaborator

Description

Fixing security alerts for JS code of landing page

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

  • by confirming that landing page works

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • Docs updated? What were the changes:

@yeldarby
Copy link
Contributor

I don’t understand this change. What are the deleted files?

@PawelPeczek-Roboflow
Copy link
Collaborator Author

Each time landing is re-generated it produces security vulnerability. The lib generating it is probably broken in that regards, so I fix each time (I am pretty sure in the meantime we were upgrading it version but no fix so far, we may check again later on). This is to get security allerts dismissed
You cannot see the change as I modified giant one-liner JS script fixing 3 instances causing issues

Copy link
Contributor

@yeldarby yeldarby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I suspect upgrading the underlying package generating it in the package.json will fix permanently; let’s do that before the next release.

@PawelPeczek-Roboflow PawelPeczek-Roboflow merged commit 31bd334 into main Aug 16, 2024
58 checks passed
@PawelPeczek-Roboflow PawelPeczek-Roboflow deleted the fix/security_issue branch August 16, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants